Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Teamsintegration #18

Merged
merged 6 commits into from
Feb 8, 2023
Merged

Teamsintegration #18

merged 6 commits into from
Feb 8, 2023

Conversation

subashc2023
Copy link
Collaborator

No description provided.

fixed loading secrets into CloudFormation
added setup steps and fixed cf template secret loading
README.md Outdated Show resolved Hide resolved
get_forecast.py Show resolved Hide resolved
get_forecast.py Show resolved Hide resolved
get_forecast.py Show resolved Hide resolved
get_forecast_cf.yaml Outdated Show resolved Hide resolved
get_forecast.py Show resolved Hide resolved
get_forecast.py Outdated Show resolved Hide resolved
get_forecast.py Outdated Show resolved Hide resolved
get_forecast.py Outdated Show resolved Hide resolved
get_forecast.py Outdated Show resolved Hide resolved
made requested changes
added role permission for GetSecretValue to CF Template
fixed readme for secret role getsecretvalue issue
get_forecast.py Show resolved Hide resolved
Copy link
Owner

@jimzucker jimzucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jimzucker jimzucker merged commit 89129c9 into jimzucker:main Feb 8, 2023
@jimzucker jimzucker mentioned this pull request Feb 8, 2023
jimzucker added a commit that referenced this pull request Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants