Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setuptools and Cython should not be listed as requirements #42

Open
SpecLad opened this issue Oct 27, 2023 · 0 comments
Open

setuptools and Cython should not be listed as requirements #42

SpecLad opened this issue Oct 27, 2023 · 0 comments

Comments

@SpecLad
Copy link

SpecLad commented Oct 27, 2023

This project does not appear to use either setuptools or Cython at runtime, so these packages should not be listed in requirements.txt. Listing them there causes unnecessary packages to be installed into the user's environment.

They are build-time dependencies, so they should be listed in pyproject.toml instead. See pycocotools for an example: https://github.com/ppwwyyxx/cocoapi/blob/4670067b35e7b65d618c9746c456fe2c1128049c/PythonAPI/pyproject.toml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant