This repository has been archived by the owner on Mar 14, 2019. It is now read-only.
Add java_library statements for providing a lib with transitive deps
#9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
as per your suggestion in the slack discussion, let's use a new |
…s exported. Also, refactor common list deduplication code.
jin
approved these changes
Feb 8, 2019
| target_import_string.append("\t\t\":%s\"," % dep_target_label) | ||
| target_import_string.append("\t],") | ||
| target_import_labels.append("\t\t\":%s\",\n" % dep_target_label) | ||
| target_import_labels = _deduplicate_list(target_import_labels) |
jin
approved these changes
Feb 11, 2019
|
Perfect! thank you. |
jin
pushed a commit
that referenced
this pull request
Feb 28, 2019
#9) * Add `java_library` statements for providing a lib with transitive deps exported. Also, refactor common list deduplication code. * Update artifact() and maven_artifact() to default to _lib targets. * Include the jar in the corresponding library. * Add library() and maven_library() to depend on java_library rules. * Address code review feedback on variable naming. * Update README with information on spec maps and library targets.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is incomplete, due to a failing test. I messaged you briefly about it on Slack, but I really wonder if the test that is failing is not even worth having.
I also made some choices that I expect you'll have thoughts on (naming, etc), and I'm happy to yield to other ways to do things, I just wanted to get this started.