Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make PaymentState.state and transaction public. #44

Merged
merged 1 commit into from May 4, 2020
Merged

Make PaymentState.state and transaction public. #44

merged 1 commit into from May 4, 2020

Conversation

yanyin1986
Copy link
Contributor

@yanyin1986 yanyin1986 commented Dec 27, 2019

Hi, with InAppPurchase v2.1.4.
I did validate the transaction which returned by the callback of addTransactionObserver.
After v2.3.0, I found I can't do that anymore.

image

It will be work after making state and transaction public.
Thanks.

@codecov
Copy link

codecov bot commented Dec 27, 2019

Codecov Report

Merging #44 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #44   +/-   ##
=======================================
  Coverage   95.25%   95.25%           
=======================================
  Files           6        6           
  Lines         253      253           
=======================================
  Hits          241      241           
  Misses         12       12
Impacted Files Coverage Δ
Sources/InAppPurchase.swift 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 119b5a9...64328ae. Read the comment docs.

@calda
Copy link

calda commented Jan 12, 2020

+1, cd4f179 broke this important functionality.

@mdcdeveloper
Copy link

+1, I have to send to server side the transactionIdentifier, that's the identifier in our app. Waiting to merge! Please! Anyway when I print it it print's out the id's so I don't see why this is not public. Thanks in advance!

Copy link

@glizik glizik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is essential.

Copy link
Owner

@jinSasaki jinSasaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the pull request. This is my mistake.
Merge and release a new version.

@jinSasaki jinSasaki merged commit fe0fe50 into jinSasaki:master May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants