Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add filter method #121

Merged
merged 5 commits into from
Jun 9, 2022
Merged

feat: add filter method #121

merged 5 commits into from
Jun 9, 2022

Conversation

davidbp
Copy link
Contributor

@davidbp davidbp commented Jun 8, 2022

Draft for 'searching' in cells without query vector (just find elements that verify the filter and return them).

@davidbp davidbp self-assigned this Jun 8, 2022
annlite/container.py Outdated Show resolved Hide resolved
@davidbp davidbp requested a review from numb3r3 June 9, 2022 09:00
@davidbp davidbp marked this pull request as ready for review June 9, 2022 09:00
@codecov
Copy link

codecov bot commented Jun 9, 2022

Codecov Report

Merging #121 (238976e) into main (e4e706e) will increase coverage by 0.69%.
The diff coverage is 93.10%.

@@            Coverage Diff             @@
##             main     #121      +/-   ##
==========================================
+ Coverage   64.29%   64.99%   +0.69%     
==========================================
  Files          22       22              
  Lines        1165     1194      +29     
==========================================
+ Hits          749      776      +27     
- Misses        416      418       +2     
Flag Coverage Δ
annlite 64.99% <93.10%> (+0.69%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
annlite/container.py 76.19% <91.66%> (+2.25%) ⬆️
annlite/index.py 57.21% <100.00%> (+1.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ce1ec2...238976e. Read the comment docs.

@numb3r3 numb3r3 merged commit a7804ba into main Jun 9, 2022
@numb3r3 numb3r3 deleted the feat-pure-filtering branch June 9, 2022 10:00
Copy link
Member

@numb3r3 numb3r3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@numb3r3 numb3r3 linked an issue Jun 10, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

implement pure filtering function
2 participants