Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add benchmark insert time #57

Merged
merged 2 commits into from Dec 14, 2021
Merged

feat: add benchmark insert time #57

merged 2 commits into from Dec 14, 2021

Conversation

davidbp
Copy link
Contributor

@davidbp davidbp commented Dec 13, 2021 •
edited

The insert time does not seem to be the core problem of why indexing takes so long

total time pqlite=38.99 seconds
total time docarraymemmap=39.58 seconds

numb3r3
numb3r3 approved these changes Dec 14, 2021
View reviewed changes
Copy link
Member

@numb3r3 numb3r3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@numb3r3 numb3r3 merged commit 0631ee5 into main Dec 14, 2021
@numb3r3 numb3r3 deleted the feat-benchmark-insert-time branch December 14, 2021 02:43
@numb3r3 numb3r3 linked an issue Dec 14, 2021 that may be closed by this pull request
PQLite: benchmark storage engine #54
Closed
@davidbp davidbp mentioned this pull request Dec 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@numb3r3 numb3r3 numb3r3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PQLite: benchmark storage engine
2 participants
@davidbp @numb3r3