Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client): raise value when embedding is empty #666

Merged
merged 2 commits into from
Mar 29, 2022
Merged

Conversation

hanxiao
Copy link
Member

@hanxiao hanxiao commented Mar 29, 2022

No description provided.

@codecov
Copy link

codecov bot commented Mar 29, 2022

Codecov Report

Merging #666 (f35f19b) into main (ae4d0ba) will decrease coverage by 0.34%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##             main     #666      +/-   ##
==========================================
- Coverage   84.00%   83.65%   -0.35%     
==========================================
  Files           2        2              
  Lines         100      104       +4     
==========================================
+ Hits           84       87       +3     
- Misses         16       17       +1     
Flag Coverage Δ
cas 83.65% <83.33%> (-0.35%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/clip_client/client.py 83.33% <80.00%> (-0.35%) ⬇️
client/clip_client/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da1dd85...f35f19b. Read the comment docs.

@hanxiao hanxiao merged commit b4624dd into main Mar 29, 2022
@hanxiao hanxiao deleted the fix-return-empty branch March 29, 2022 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant