Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: download with resume #689

Merged
merged 3 commits into from
Apr 24, 2022
Merged

fix: download with resume #689

merged 3 commits into from
Apr 24, 2022

Conversation

numb3r3
Copy link
Member

@numb3r3 numb3r3 commented Apr 22, 2022

resume downloading of the model. Now if the downloading is interrupted (not completed) at the first time, the service cannot be started anymore.

@codecov
Copy link

codecov bot commented Apr 22, 2022

Codecov Report

Merging #689 (700df50) into main (2558d73) will increase coverage by 0.17%.
The diff coverage is 93.33%.

@@            Coverage Diff             @@
##             main     #689      +/-   ##
==========================================
+ Coverage   78.68%   78.86%   +0.17%     
==========================================
  Files          11       11              
  Lines         793      809      +16     
==========================================
+ Hits          624      638      +14     
- Misses        169      171       +2     
Flag Coverage Δ
cas 78.86% <93.33%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/clip_server/model/clip.py 86.33% <92.30%> (+0.15%) ⬆️
client/clip_client/__init__.py 100.00% <100.00%> (ø)
server/clip_server/__init__.py 100.00% <100.00%> (ø)
server/clip_server/model/clip_onnx.py 81.81% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6eadbfb...700df50. Read the comment docs.

@numb3r3 numb3r3 merged commit 3bd7464 into main Apr 24, 2022
@numb3r3 numb3r3 deleted the fix-resume-download branch April 24, 2022 07:09
numb3r3 added a commit that referenced this pull request May 4, 2022
* fix: download with resume

* fix: pass a valid user-agent

* fix: unttest
samsja pushed a commit that referenced this pull request May 16, 2022
* fix: download with resume

* fix: pass a valid user-agent

* fix: unttest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant