Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helper): add version check for client and server #696

Merged
merged 5 commits into from
Apr 26, 2022

Conversation

hanxiao
Copy link
Member

@hanxiao hanxiao commented Apr 26, 2022

No description provided.

@codecov
Copy link

codecov bot commented Apr 26, 2022

Codecov Report

Merging #696 (76434b2) into main (b727086) will decrease coverage by 1.22%.
The diff coverage is 58.73%.

@@            Coverage Diff             @@
##             main     #696      +/-   ##
==========================================
- Coverage   79.88%   78.66%   -1.23%     
==========================================
  Files          11       12       +1     
  Lines         870      928      +58     
==========================================
+ Hits          695      730      +35     
- Misses        175      198      +23     
Flag Coverage Δ
cas 78.66% <58.73%> (-1.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/clip_server/__main__.py 0.00% <0.00%> (ø)
server/clip_server/helper.py 42.85% <36.00%> (-57.15%) ⬇️
client/clip_client/helper.py 84.61% <84.61%> (ø)
client/clip_client/__init__.py 100.00% <100.00%> (ø)
server/clip_server/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 234650f...76434b2. Read the comment docs.

@hanxiao hanxiao merged commit ca5f302 into main Apr 26, 2022
@hanxiao hanxiao deleted the feat-version-check branch April 26, 2022 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant