Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upload torch executor #723

Merged
merged 46 commits into from
Jun 15, 2022
Merged

feat: upload torch executor #723

merged 46 commits into from
Jun 15, 2022

Conversation

ZiniuYu
Copy link
Member

@ZiniuYu ZiniuYu commented May 17, 2022

Also update the black version

@codecov
Copy link

codecov bot commented May 17, 2022

Codecov Report

Merging #723 (2cb016a) into main (eca1e70) will decrease coverage by 13.16%.
The diff coverage is 64.28%.

@@             Coverage Diff             @@
##             main     #723       +/-   ##
===========================================
- Coverage   81.78%   68.62%   -13.17%     
===========================================
  Files          17       17               
  Lines        1208     1208               
===========================================
- Hits          988      829      -159     
- Misses        220      379      +159     
Flag Coverage Δ
cas 68.62% <64.28%> (-13.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/clip_server/executors/clip_tensorrt.py 0.00% <0.00%> (-100.00%) ⬇️
server/clip_server/model/clip_trt.py 0.00% <0.00%> (-92.31%) ⬇️
client/clip_client/__init__.py 100.00% <100.00%> (ø)
server/clip_server/__init__.py 100.00% <100.00%> (ø)
server/clip_server/executors/clip_hg.py 86.07% <100.00%> (ø)
server/clip_server/executors/clip_onnx.py 85.48% <100.00%> (ø)
server/clip_server/executors/clip_torch.py 87.03% <100.00%> (ø)
server/clip_server/executors/helper.py 100.00% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2083f09...2cb016a. Read the comment docs.

server/clip_server/executors/clip_torch.py Outdated Show resolved Hide resolved
server/clip_server/executors/clip_torch.py Outdated Show resolved Hide resolved
@ZiniuYu ZiniuYu requested a review from numb3r3 May 17, 2022 06:32
@numb3r3 numb3r3 changed the title chore(server): add docstr feat: upload torch executor May 18, 2022
@numb3r3 numb3r3 force-pushed the clip_jina_hub branch 2 times, most recently from 1e07883 to 3f81875 Compare May 27, 2022 09:28
@ZiniuYu ZiniuYu force-pushed the clip_jina_hub branch 2 times, most recently from 441f40d to 5b8e914 Compare June 1, 2022 03:35
@github-actions github-actions bot removed the area/docs label Jun 1, 2022
@github-actions
Copy link

github-actions bot commented Jun 1, 2022

📝 Docs are deployed on https://ft-clip_jina_hub--jina-docs.netlify.app 🎉

@numb3r3 numb3r3 marked this pull request as draft June 9, 2022 02:51
@numb3r3 numb3r3 force-pushed the clip_jina_hub branch 2 times, most recently from 175fc74 to 7b955a1 Compare June 10, 2022 09:39
@hanxiao
Copy link
Member

hanxiao commented Jun 13, 2022

Please fix this https://jinaai.slack.com/archives/C038JR9U6F6/p1655123876925349 as well. Explain all questions I mentioned in very details

@github-actions github-actions bot added size/l and removed size/m labels Jun 15, 2022
@github-actions github-actions bot added size/m and removed size/l labels Jun 15, 2022
@github-actions github-actions bot added size/l and removed size/m labels Jun 15, 2022
.github/README-exec/torch.readme.md Outdated Show resolved Hide resolved
.github/README-exec/torch.readme.md Outdated Show resolved Hide resolved
.github/README-exec/torch.readme.md Outdated Show resolved Hide resolved
.github/README-exec/torch.readme.md Outdated Show resolved Hide resolved
.github/README-exec/torch.readme.md Outdated Show resolved Hide resolved
.github/README-exec/torch.readme.md Show resolved Hide resolved
@ZiniuYu
Copy link
Member Author

ZiniuYu commented Jun 15, 2022

Remember to add a link to ONNX runtime and vice versa

@numb3r3 numb3r3 marked this pull request as ready for review June 15, 2022 09:59
@numb3r3 numb3r3 merged commit 4d069a8 into main Jun 15, 2022
@numb3r3 numb3r3 deleted the clip_jina_hub branch June 15, 2022 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants