Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add JCloud deployment docs #739

Merged
merged 13 commits into from
Jun 8, 2022
Merged

docs: add JCloud deployment docs #739

merged 13 commits into from
Jun 8, 2022

Conversation

ZiniuYu
Copy link
Member

@ZiniuYu ZiniuYu commented Jun 1, 2022

This pull request adds docs for how to deploy CLIP on JCloud

@codecov
Copy link

codecov bot commented Jun 1, 2022

Codecov Report

Merging #739 (9a4145e) into main (5e06667) will decrease coverage by 14.64%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##             main     #739       +/-   ##
===========================================
- Coverage   81.16%   66.52%   -14.65%     
===========================================
  Files          16       16               
  Lines        1168     1168               
===========================================
- Hits          948      777      -171     
- Misses        220      391      +171     
Flag Coverage Δ
cas 66.52% <100.00%> (-14.65%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/clip_client/__init__.py 100.00% <100.00%> (ø)
server/clip_server/__init__.py 100.00% <100.00%> (ø)
server/clip_server/executors/clip_tensorrt.py 0.00% <0.00%> (-93.45%) ⬇️
server/clip_server/model/clip_trt.py 0.00% <0.00%> (-92.31%) ⬇️
server/clip_server/model/trt_utils.py 0.00% <0.00%> (-83.52%) ⬇️
server/clip_server/executors/clip_onnx.py 82.89% <0.00%> (-2.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b88e99...9a4145e. Read the comment docs.

@numb3r3
Copy link
Member

numb3r3 commented Jun 1, 2022

Let's hold on this PR until jcloud works

docs/how-to/jcloud_deploy.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
Copy link
Member

@hanxiao hanxiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR name docs: ... not Docs:

@ZiniuYu ZiniuYu changed the title Docs: add JCloud deployment docs docs: add JCloud deployment docs Jun 6, 2022
docs/user-guides/server.md Outdated Show resolved Hide resolved
docs/user-guides/server.md Outdated Show resolved Hide resolved

```

### Connect from Client
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a new header is not necessary here. Just follow the above chapter Serve with TLS

@github-actions
Copy link

github-actions bot commented Jun 8, 2022

📝 Docs are deployed on https://ft-jcloud_docs--jina-docs.netlify.app 🎉

Copy link
Member

@numb3r3 numb3r3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@numb3r3 numb3r3 merged commit 130108c into main Jun 8, 2022
@numb3r3 numb3r3 deleted the jcloud_docs branch June 8, 2022 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants