Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add clip_hg executor #740

Merged
merged 11 commits into from
Jun 9, 2022
Merged

feat: add clip_hg executor #740

merged 11 commits into from
Jun 9, 2022

Conversation

ZiniuYu
Copy link
Member

@ZiniuYu ZiniuYu commented Jun 1, 2022

No description provided.

@codecov
Copy link

codecov bot commented Jun 1, 2022

Codecov Report

Merging #740 (99a974b) into main (5e06667) will increase coverage by 0.58%.
The diff coverage is 85.45%.

@@            Coverage Diff             @@
##             main     #740      +/-   ##
==========================================
+ Coverage   81.16%   81.74%   +0.58%     
==========================================
  Files          16       17       +1     
  Lines        1168     1271     +103     
==========================================
+ Hits          948     1039      +91     
- Misses        220      232      +12     
Flag Coverage 螖
cas 81.74% <85.45%> (+0.58%) 猬嗭笍

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
server/clip_server/model/model.py 62.16% <80.00%> (酶)
server/clip_server/executors/clip_hg.py 85.43% <85.43%> (酶)
client/clip_client/__init__.py 100.00% <100.00%> (酶)
server/clip_server/__init__.py 100.00% <100.00%> (酶)
client/clip_client/client.py 88.33% <0.00%> (+1.11%) 猬嗭笍
server/clip_server/executors/helper.py 100.00% <0.00%> (+1.69%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 12ede83...99a974b. Read the comment docs.

Copy link
Member

@numb3r3 numb3r3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • add rank() endpoint
  • add unittest
  • add dependency of transformers into setup.py

server/clip_server/executors/clip_hg.py Outdated Show resolved Hide resolved
server/clip_server/executors/clip_hg.py Outdated Show resolved Hide resolved
server/clip_server/executors/clip_hg.py Outdated Show resolved Hide resolved
Copy link
Member

@hanxiao hanxiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the point of this PR? is it just for practicing how to implement executor? I don't see any business value from this

@ZiniuYu ZiniuYu linked an issue Jun 6, 2022 that may be closed by this pull request
@numb3r3
Copy link
Member

numb3r3 commented Jun 7, 2022

@hanxiao This PR is mainly developed for the community. If the users who already use (or finetune) the clip model from huggingface, then this PR can enable them to easily enjoy the power of jina.

@github-actions
Copy link

github-actions bot commented Jun 7, 2022

馃摑 Docs are deployed on https://ft-clip_hg--jina-docs.netlify.app 馃帀

server/clip_server/executors/clip_hg.py Show resolved Hide resolved
server/setup.py Outdated Show resolved Hide resolved
server/clip_server/executors/clip_hg.py Outdated Show resolved Hide resolved
@numb3r3 numb3r3 marked this pull request as ready for review June 8, 2022 03:27
@numb3r3 numb3r3 merged commit d675148 into main Jun 9, 2022
@numb3r3 numb3r3 deleted the clip_hg branch June 9, 2022 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create and upload clip executor
3 participants