Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add traversal paths #748

Merged
merged 11 commits into from
Jun 10, 2022
Merged

feat: add traversal paths #748

merged 11 commits into from
Jun 10, 2022

Conversation

numb3r3
Copy link
Member

@numb3r3 numb3r3 commented Jun 10, 2022

No description provided.

@codecov
Copy link

codecov bot commented Jun 10, 2022

Codecov Report

Merging #748 (eca7708) into main (752202f) will increase coverage by 0.27%.
The diff coverage is 96.96%.

@@            Coverage Diff             @@
##             main     #748      +/-   ##
==========================================
+ Coverage   81.49%   81.76%   +0.27%     
==========================================
  Files          17       17              
  Lines        1232     1212      -20     
==========================================
- Hits         1004      991      -13     
+ Misses        228      221       -7     
Flag Coverage 螖
cas 81.76% <96.96%> (+0.27%) 猬嗭笍

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
client/clip_client/client.py 88.04% <88.88%> (-0.29%) 猬囷笍
server/clip_server/executors/clip_onnx.py 85.48% <90.90%> (+0.76%) 猬嗭笍
client/clip_client/__init__.py 100.00% <100.00%> (酶)
server/clip_server/__init__.py 100.00% <100.00%> (酶)
server/clip_server/executors/clip_hg.py 86.07% <100.00%> (+0.54%) 猬嗭笍
server/clip_server/executors/clip_tensorrt.py 100.00% <100.00%> (+7.01%) 猬嗭笍
server/clip_server/executors/clip_torch.py 87.03% <100.00%> (+1.09%) 猬嗭笍
server/clip_server/executors/helper.py 100.00% <100.00%> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 52a8b0a...eca7708. Read the comment docs.

@numb3r3 numb3r3 requested a review from ZiniuYu June 10, 2022 05:48
Copy link
Member

@ZiniuYu ZiniuYu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add some test cases

client/clip_client/client.py Outdated Show resolved Hide resolved
Copy link
Member

@ZiniuYu ZiniuYu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hanxiao
Copy link
Member

hanxiao commented Jun 10, 2022

traversal path should not be handled in CAS, user should first traverse and then send via client

@numb3r3
Copy link
Member Author

numb3r3 commented Jun 10, 2022

traversal path should not be handled in CAS, user should first traverse and then send via client

The executors in the CAS will then be uploaded to the hub. So I think the traversal_paths support is necessary. And of course, if the user uses CAS client, the recommended way is to traverse first (the traversal_paths will not be mentioned in CAS doc).

@numb3r3 numb3r3 merged commit 4fe5a1b into main Jun 10, 2022
@numb3r3 numb3r3 deleted the feat-traversal-paths branch June 10, 2022 09:33
hanxiao added a commit that referenced this pull request Jun 10, 2022
hanxiao added a commit that referenced this pull request Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants