feat: encode text first when both text and uri are presented #795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #795 +/- ##
==========================================
+ Coverage 83.75% 83.79% +0.04%
==========================================
Files 21 21
Lines 1440 1438 -2
==========================================
- Hits 1206 1205 -1
+ Misses 234 233 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
numb3r3
requested changes
Aug 4, 2022
ZiniuYu
changed the title
numb3r3
requested changes
Aug 4, 2022
| Document(text='goodbye, world'), | ||
| Document( | ||
| text='hello, world', | ||
| uri='https://docarray.jina.ai/_static/favicon.png', |
There was a problem hiding this comment.
also coverage the docs with blob and tensor
There was a problem hiding this comment.
tensor = [0, 1, 2, 3] or tensor = np.array([0, 1, 2, 3])
|
@ZiniuYu BTW, do we need also to update the client side? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In previous versions, when a doc contains both text and URI fields, clip_server will treat it as an image doc.
In this pr we encode text first since the text is a content attribute and URI is only a source of content.
So now when a doc has text and URI fields, we will consider it as a text doc.