fix: onnx package conflict during setup #894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size/xs
component/server
size/s
area/testing
and removed
size/xs
labels
ZiniuYu
force-pushed
the
fix-onnx-docker
branch
from
6e07f2e
to
b9dcde3
Compare
Codecov Report
@@ Coverage Diff @@
## main #894 +/- ##
===========================================
- Coverage 83.08% 71.60% -11.49%
===========================================
Files 22 23 +1
Lines 1531 1567 +36
===========================================
- Hits 1272 1122 -150
- Misses 259 445 +186
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
numb3r3
requested changes
Feb 21, 2023
server/setup.py
Outdated
| 'onnx', | ||
| 'onnxmltools', | ||
| 'onnxruntime', |
There was a problem hiding this comment.
As you mentioned, we can always install onnxruntime-gpu?
There was a problem hiding this comment.
I've tested on x86 machines with/without GPU, both work fine. The CI failed for unknown reasons
numb3r3
requested changes
Feb 22, 2023
|
📝 Docs are deployed on https://ft-fix-onnx-docker--jina-docs.netlify.app 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a package conflict with
onnxruntimeandonnxruntime-gpuin setup. If we install both packages, we are not able to run onnx using gpu. Installing onlyonnxruntime-gpuenables clip_server to run both on CPU and GPU.This PR also corrects the instructions on running docker image in different runtimes.
This PR also replaces the broken images in test files
Notes: onnxruntime is fixed at 1.13.1 to pass the test_ranker
nvidia-tensorrt is fixed at 8.4.1.5 to pass trt related tests