Skip to content

Commit

Permalink
feat: bump up python to 3.8.0
Browse files Browse the repository at this point in the history
  • Loading branch information
mapleeit committed Jul 10, 2023
1 parent 951928c commit 1219a78
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 5 deletions.
5 changes: 3 additions & 2 deletions normalizer/core.py
Original file line number Diff line number Diff line change
Expand Up @@ -382,6 +382,7 @@ def normalize(
:param dry_run: if True, dry_run the file dumps
:param dockerfile: custom dockerfile path
:param dockerfile_syntax: custom dockerfile syntax
:param _argv: other arguments
:return: normalized Executor model
Expand Down Expand Up @@ -618,7 +619,7 @@ def normalize(

base_images, dep_tools = prelude(imports)
jina_version = choose_jina_version(meta['jina'])
py_version = meta.get('python', '3.7.0')
py_version = meta.get('python', '3.8.0')

jina_image_tag = get_jina_image_tag(jina_version, py_version)

Expand Down Expand Up @@ -689,7 +690,7 @@ def normalize(
new_dockerfile.set_entrypoint(entrypoint_value)

if 'docarray' in meta and '__jina__.Dockerfile' not in str(dockerfile_path):
dockerfile.add_docarray_install(meta["docarray"])
dockerfile.add_docarray_install(meta['docarray'])
if not dry_run:
dockerfile.dump(dockerfile_path)

Expand Down
2 changes: 1 addition & 1 deletion tests/cases/executor_1/Dockerfile.expect
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# This file is automatically generated by Jina executor normalizer plugin.
# It is not intended for manual editing.

FROM jinaai/jina:2-py37-perf
FROM jinaai/jina:2-py38-perf

# setup the workspace
COPY . /workspace
Expand Down
2 changes: 1 addition & 1 deletion tests/cases/executor_2/Dockerfile.expect
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# This file is automatically generated by Jina executor normalizer plugin.
# It is not intended for manual editing.

FROM jinaai/jina:2-py37-perf
FROM jinaai/jina:2-py38-perf

# setup the workspace
COPY . /workspace
Expand Down
2 changes: 1 addition & 1 deletion tests/cases/executor_6/Dockerfile.expect
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# This file is automatically generated by Jina executor normalizer plugin.
# It is not intended for manual editing.

FROM jinaai/jina:2-py37-perf
FROM jinaai/jina:2-py38-perf

# setup the workspace
COPY . /workspace
Expand Down

0 comments on commit 1219a78

Please sign in to comment.