Skip to content

Commit

Permalink
feat(normalizer): uninstall jina first when upgrading jina
Browse files Browse the repository at this point in the history
  • Loading branch information
mapleeit committed Jan 25, 2022
1 parent feec7b3 commit abf39ea
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion normalizer/resources/templates/dockerfile.base
Original file line number Diff line number Diff line change
Expand Up @@ -26,4 +26,7 @@ RUN unset JINA_PIP_INSTALL_CORE && \

ENV JINA_PIP_INSTALL_PERF=1

RUN if [ "${ARG_JINA_VERSION}" = 'master' ]; then pip install --upgrade --pre jina; else pip install --upgrade jina==${ARG_JINA_VERSION}; fi
# Need to uninstall jina first when upgrading 2.x to 3.x
# https://github.com/jina-ai/jina/issues/4194
RUN pip uninstall -y jina && \
if [ "${ARG_JINA_VERSION}" = 'master' ]; then pip install --upgrade --pre jina; else pip install --upgrade jina==${ARG_JINA_VERSION}; fi

0 comments on commit abf39ea

Please sign in to comment.