Skip to content

Commit

Permalink
fix(tests): remove base_image related tests
Browse files Browse the repository at this point in the history
  • Loading branch information
numb3r3 committed Aug 19, 2021
1 parent e858486 commit eb92aa9
Show file tree
Hide file tree
Showing 2 changed files with 31 additions and 31 deletions.
6 changes: 3 additions & 3 deletions tests/test_core.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ def test_prelude():
]

base_images, tools = core.prelude(imports)
assert base_images == set(
['tensorflow/tensorflow:2.5.0', 'pytorch/pytorch:1.6.0-cuda10.2-cudnn7-runtime']
)
# assert base_images == set(
# ['tensorflow/tensorflow:2.5.0', 'pytorch/pytorch:1.6.0-cuda10.2-cudnn7-runtime']
# )
assert tools == set(['git'])
56 changes: 28 additions & 28 deletions tests/test_deps.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,31 +30,31 @@ def test_get_dep_tools():
assert deps.get_dep_tools(pkg) == ['git']


@pytest.mark.parametrize(
'package, expect_base_image',
[
(
deps.Package(name='tensorflow', version='2.5.0'),
'tensorflow/tensorflow:2.5.0',
),
(
deps.Package(name='tensorflow-cpu', version='2.1.0'),
'tensorflow/tensorflow:2.1.0-py3',
),
(
deps.Package(name='tensorflow-gpu', version='2.1.0'),
'tensorflow/tensorflow:2.1.0-gpu-py3',
),
(
deps.Package(name='tensorflow-gpu', version='1.12.0'),
'tensorflow/tensorflow:1.12.0-gpu-py3',
),
(deps.Package(name='pytorch', version='1.8.0+cpu'), 'bitnami/pytorch:1.8.0'),
(
deps.Package(name='pytorch', version='1.8.0'),
'pytorch/pytorch:1.8.0-cuda10.2-cudnn7-runtime',
),
],
)
def test_get_base_images(package, expect_base_image):
assert deps.get_baseimage(package) == expect_base_image
# @pytest.mark.parametrize(
# 'package, expect_base_image',
# [
# (
# deps.Package(name='tensorflow', version='2.5.0'),
# 'tensorflow/tensorflow:2.5.0',
# ),
# (
# deps.Package(name='tensorflow-cpu', version='2.1.0'),
# 'tensorflow/tensorflow:2.1.0-py3',
# ),
# (
# deps.Package(name='tensorflow-gpu', version='2.1.0'),
# 'tensorflow/tensorflow:2.1.0-gpu-py3',
# ),
# (
# deps.Package(name='tensorflow-gpu', version='1.12.0'),
# 'tensorflow/tensorflow:1.12.0-gpu-py3',
# ),
# (deps.Package(name='pytorch', version='1.8.0+cpu'), 'bitnami/pytorch:1.8.0'),
# (
# deps.Package(name='pytorch', version='1.8.0'),
# 'pytorch/pytorch:1.8.0-cuda10.2-cudnn7-runtime',
# ),
# ],
# )
# def test_get_base_images(package, expect_base_image):
# assert deps.get_baseimage(package) == expect_base_image

0 comments on commit eb92aa9

Please sign in to comment.