Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add docarray install instructions in dockerfile #65

Merged
merged 3 commits into from
May 29, 2023

Conversation

redjson
Copy link
Contributor

@redjson redjson commented May 24, 2023

No description provided.

@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Merging #65 (57bf4ef) into main (5c99892) will increase coverage by 0.40%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #65      +/-   ##
==========================================
+ Coverage   78.35%   78.75%   +0.40%     
==========================================
  Files           9        9              
  Lines         582      593      +11     
==========================================
+ Hits          456      467      +11     
  Misses        126      126              
Impacted Files Coverage Δ
normalizer/docker/parser.py 89.09% <100.00%> (+0.74%) ⬆️

... and 1 file with indirect coverage changes

@redjson redjson requested a review from mapleeit May 26, 2023 11:10
@redjson redjson marked this pull request as ready for review May 26, 2023 11:10
@@ -0,0 +1,4 @@
jtype: executor_7
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
jtype: executor_7
jtype: executor_9

@@ -0,0 +1,4 @@
jtype: executor_7
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
jtype: executor_7
jtype: executor_8

from jina import Executor, DocumentArray, requests


class executor_7(Executor):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
class executor_7(Executor):
class executor_9(Executor):

@@ -0,0 +1,2 @@
# executor_7
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# executor_7
# executor_9

from jina import Executor, DocumentArray, requests


class executor_7(Executor):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
class executor_7(Executor):
class executor_8(Executor):

@@ -0,0 +1,2 @@
# executor_7
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# executor_7
# executor_8

@redjson redjson merged commit d28b5a7 into main May 29, 2023
3 checks passed
@redjson redjson deleted the feat-docarray-v2 branch May 29, 2023 05:55
@nan-wang
Copy link
Member

🎉 This PR is included in version 0.13.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants