Skip to content

Commit

Permalink
refactor: show progress when save model (#483)
Browse files Browse the repository at this point in the history
* refactor: show progress when save model

* chore: losen version requirements

* chore: losen version requirements

* refactor: adjust hubble python client variables

* chore: update changelog
  • Loading branch information
bwanglzu committed Jul 12, 2022
1 parent 3c33dec commit 9657672
Show file tree
Hide file tree
Showing 3 changed files with 23 additions and 5 deletions.
16 changes: 16 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,26 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).


## [Unreleased] - 2022-MM-DD

### Added

### Removed

### Changed

- `save_artifact` should show progress while downloading. ([#483](https://github.com/jina-ai/finetuner/pull/483))

- Give more flexibility on dependency versions. ([#483](https://github.com/jina-ai/finetuner/pull/483))

### Fixed


## [0.5.0] - 2022-06-30

### Added

- Docs 0.4.1 backup. ([#462](https://github.com/jina-ai/finetuner/pull/462))

- Add Jina integration section in the docs. ([#467](https://github.com/jina-ai/finetuner/pull/467))
Expand Down
4 changes: 3 additions & 1 deletion finetuner/hubble.py
Original file line number Diff line number Diff line change
Expand Up @@ -81,4 +81,6 @@ def download_artifact(
artifact_id = run['artifact_id']
path = os.path.join(directory, f'{run["name"]}.zip')

return client.hubble_client.download_artifact(id=artifact_id, path=path)
return client.hubble_client.download_artifact(
id=artifact_id, f=path, show_progress=True
)
8 changes: 4 additions & 4 deletions requirements.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
docarray[common]==0.13.19
jina-hubble-sdk==0.5.1
requests==2.27.1
rich==12.4.4
docarray[common]>=0.13.19
jina-hubble-sdk>=0.8.0
requests>=2.27.1
rich>=12.4.4

0 comments on commit 9657672

Please sign in to comment.