feat(tuner): add gpu for paddle and tf #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwanglzu
changed the title
github-actions
bot
added
size/s
area/core
area/testing
hanxiao
reviewed
Oct 14, 2021
| paddlepaddle-gpu | ||
| torch | ||
| torchvision | ||
| scipy |
There was a problem hiding this comment.
this is used in creating easy data for overfitting test if i remember correctly cc @tadejsv
There was a problem hiding this comment.
Yes exactly, so I have a one-liner to calculate distances
hanxiao
reviewed
Oct 14, 2021
.github/requirements-cicd-gpu.txt
Outdated
| @@ -0,0 +1,6 @@ | |||
| numpy | |||
There was a problem hiding this comment.
not necessary, as base dep is jina and jina includes numpy already
hanxiao
reviewed
Oct 14, 2021
| @@ -128,24 +128,35 @@ def fit( | |||
|
|
|||
| optimizer = tf.keras.optimizers.RMSprop(learning_rate=0.01) | |||
|
|
|||
| if device == 'cuda': | |||
There was a problem hiding this comment.
do we have the same device name across all frameworks, what @tadejsv using in pytorch?
There was a problem hiding this comment.
yes we agreed to use cuda and cpu.
tadejsv
approved these changes
Oct 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for tensorflow, since it's session based, i can not verify it's using gpu for training in an explicit way, however, printing los on gpu machine shows that it's using gpu: