feat: refactor head layers #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size/m
area/entrypoint
area/testing
added 10 commits
October 15, 2021 12:10
hanxiao
reviewed
Oct 17, 2021
|
i think the overall risk of this design is it is strongly biased on pytorch & paddle, and breaking some prev efforts on unifying keras & pytorch & paddle implementations. It is true that supporting pytorch & paddle is easy, but a pattern that fits all three frameworks is tricky and that's what this project is about. |
# Conflicts: # finetuner/tuner/base.py # finetuner/tuner/paddle/__init__.py # finetuner/tuner/pytorch/__init__.py
|
@hanxiao wait, my PR is not finished yet.I think the same thing can be done in Keras (tensorflow) as in pytorch |
|
yes, let me try on this branch, I think I can finish this PR today |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.