Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(tuner): add docstrings #148

Merged
merged 4 commits into from
Oct 19, 2021
Merged

docs(tuner): add docstrings #148

merged 4 commits into from
Oct 19, 2021

Conversation

tadejsv
Copy link
Contributor

@tadejsv tadejsv commented Oct 19, 2021

No description provided.

@codecov
Copy link

codecov bot commented Oct 19, 2021

The author of this PR, tadejsv, is not an activated member of this organization on Codecov.
Please activate this user on Codecov to display this PR comment.
Coverage data is still being uploaded to Codecov.io for purposes of overall coverage calculations.
Please don't hesitate to email us at success@codecov.io with any questions.

Copy link
Member

@bwanglzu bwanglzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments, great work!

finetuner/tuner/pytorch/losses.py Outdated Show resolved Hide resolved
finetuner/tuner/paddle/losses.py Show resolved Hide resolved
Co-authored-by: Wang Bo <bo.wang@jina.ai>
Copy link
Member

@bwanglzu bwanglzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tadejsv tadejsv merged commit 6fd3e1e into main Oct 19, 2021
@tadejsv tadejsv deleted the docstrings branch October 19, 2021 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants