feat(helper): set_embedding function for all frameworks #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size/m
area/core
area/testing
Codecov Report
@@ Coverage Diff @@
## main #163 +/- ##
==========================================
+ Coverage 84.90% 85.70% +0.79%
==========================================
Files 24 25 +1
Lines 1166 1189 +23
==========================================
+ Hits 990 1019 +29
+ Misses 176 170 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
hanxiao
changed the title
hanxiao
commented
Oct 23, 2021
Comment on lines
+40
to
+51
| def test_embedding_docs(framework, tmpdir): | ||
| # works for DA | ||
| embed_model = embed_models[framework]() | ||
| docs = DocumentArray(generate_fashion_match(num_total=100)) | ||
| set_embeddings(docs, embed_model) | ||
| assert docs.embeddings.shape == (100, 32) | ||
|
|
||
| # works for DAM | ||
| dam = DocumentArrayMemmap(tmpdir) | ||
| dam.extend(generate_fashion_match(num_total=42)) | ||
| set_embeddings(dam, embed_model) | ||
| assert dam.embeddings.shape == (42, 32) |
There was a problem hiding this comment.
@bwanglzu could you add some pytest mark to allow gpu test on this as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.