Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): return model and summary in highlevel fit #175

Merged
merged 1 commit into from
Oct 26, 2021

Conversation

hanxiao
Copy link
Member

@hanxiao hanxiao commented Oct 26, 2021

No description provided.

Copy link
Member

@bwanglzu bwanglzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Ill apply some more robust testing to assert ndim of output model and weights are updated.

@codecov
Copy link

codecov bot commented Oct 26, 2021

Codecov Report

Merging #175 (03053f0) into main (115a0aa) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #175      +/-   ##
==========================================
- Coverage   87.29%   87.28%   -0.02%     
==========================================
  Files          25       25              
  Lines        1196     1195       -1     
==========================================
- Hits         1044     1043       -1     
  Misses        152      152              
Flag Coverage Δ
finetuner 87.28% <50.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
finetuner/tuner/summary.py 94.33% <ø> (-0.11%) ⬇️
finetuner/__init__.py 70.37% <50.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 115a0aa...03053f0. Read the comment docs.

@hanxiao hanxiao merged commit 320ec5d into main Oct 26, 2021
@hanxiao hanxiao deleted the fix-highlevel-fit-return branch October 26, 2021 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants