Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: replace content to uri if use image #484

Merged
merged 6 commits into from Jul 13, 2022
Merged

Conversation

bwanglzu
Copy link
Member

@bwanglzu bwanglzu commented Jul 12, 2022

This PR fixes prepare training data section, when user give an image uri, this image uri should use uri property rather than content.


  • This PR references an open issue
  • I have added a line about this change to CHANGELOG

@github-actions github-actions bot added size/s and removed size/xs labels Jul 12, 2022
@bwanglzu bwanglzu marked this pull request as ready for review July 12, 2022 20:33
CHANGELOG.md Outdated
@@ -20,6 +20,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Fixed

- Use `uri` to represent image content when creating training data. ([#484](https://github.com/jina-ai/finetuner/pull/484))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you specify that this refers to a code snippet in the docs?

@github-actions
Copy link

📝 Docs are deployed on https://ft-docs-fix-trianing-data--jina-docs.netlify.app 🎉

@bwanglzu bwanglzu merged commit c72dc4d into main Jul 13, 2022
@bwanglzu bwanglzu deleted the docs-fix-trianing-data branch July 13, 2022 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants