feat: add artifact id and token endpoint #485
Conversation
github-actions
bot
added
area/entrypoint
area/testing
finetuner/__init__.py
Outdated
| def get_token() -> str: | ||
| """Get user token. | ||
|
|
||
| This is a helper function to get token and pull artifact from cloud storage. |
There was a problem hiding this comment.
the docstring is confusing. This function does not download the artifact
finetuner/exception.py
Outdated
| ... | ||
|
|
||
|
|
||
| class UserNotLoginError(Exception): |
finetuner/run.py
Outdated
| status = self.status()[STATUS] | ||
| if status in [CREATED, STARTED]: | ||
| raise RunInProgressError( | ||
| 'The run needs to be finished in order to save the model.' |
| run_name=self._name, | ||
| directory=directory, | ||
| ) | ||
|
|
||
| def artifact_id(self): |
There was a problem hiding this comment.
this should be a property. Otherwise rename to get_artifact_id
There was a problem hiding this comment.
well I think all should be properties 😛
There was a problem hiding this comment.
i believe status() and logs() should be get_, the rest could be property
There was a problem hiding this comment.
having static ones as properties and non-statics with get_ makes sense to me, but I'm slightly leaning towards what George suggested because it looks simpler and more elegant
| run_name=self._name, | ||
| directory=directory, | ||
| ) | ||
|
|
||
| def artifact_id(self): |
There was a problem hiding this comment.
having static ones as properties and non-statics with get_ makes sense to me, but I'm slightly leaning towards what George suggested because it looks simpler and more elegant
This PR allows user to get user token from Hubble, and get artifact id once fine-tuning is done. Usage:
This allows user to directly pull artifact inside
FinetunerExecutorusingtokenandartifactasartifact_id.This PR also did some minor refactoring on
download_artifactand error handling.A follow up PR will be created to update documentation including the usage of
FinetunerExecutor.