Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: move install instructions #518

Merged
merged 3 commits into from
Aug 31, 2022
Merged

docs: move install instructions #518

merged 3 commits into from
Aug 31, 2022

Conversation

guenthermi
Copy link
Member

@guenthermi guenthermi commented Aug 30, 2022

Move Install Instructions in Docs

I added the install instructions of the README to the into page of the documentation and moved the install instruction from the "Walkthrough" section to the top level to have it displayed directly in the sidebar.

  • This PR references an open issue
  • I have added a line about this change to CHANGELOG

@guenthermi guenthermi changed the title docs: move install install instructions docs: move install instructions Aug 30, 2022
@guenthermi guenthermi linked an issue Aug 30, 2022 that may be closed by this pull request
Copy link
Member

@gmastrapas gmastrapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe name the section Installation instead of Install? Also there is a tab called basic install. We dont need this tab, there is only one way to install

@github-actions
Copy link

📝 Docs are deployed on https://ft-docs-restructure-docs-516--jina-docs.netlify.app 🎉

Copy link
Member

@bwanglzu bwanglzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@guenthermi guenthermi merged commit 829db26 into main Aug 31, 2022
@guenthermi guenthermi deleted the docs-restructure-docs-516 branch August 31, 2022 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(Docs) Restructure Finetuner Docs
3 participants