Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: adopt changes in open clip models #528

Merged
merged 2 commits into from Sep 8, 2022
Merged

Conversation

bwanglzu
Copy link
Member

@bwanglzu bwanglzu commented Sep 8, 2022

Starting from 0.9.4, we'll support much more models as backbones for fine-tune. in this PR we add new stubs and documentation.

documentation change: https://ft-refactor-stubs--jina-docs.netlify.app/refactor-stubs/walkthrough/choose-backbone/#backbone-model

B0381758-2B16-4729-AD6E-A4DFA8F4AA39


  • This PR references an open issue
  • I have added a line about this change to CHANGELOG

@bwanglzu bwanglzu marked this pull request as ready for review September 8, 2022 11:56
@github-actions
Copy link

github-actions bot commented Sep 8, 2022

📝 Docs are deployed on https://ft-refactor-stubs--jina-docs.netlify.app 🎉

Copy link
Member

@guenthermi guenthermi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, if it is possible, I would prefer to not shorten the model name with "..." for sentence-transformers/msmarco-distilbert-base-v3 as it was before.

@bwanglzu bwanglzu merged commit 29f1dc2 into main Sep 8, 2022
@bwanglzu bwanglzu deleted the refactor-stubs branch September 8, 2022 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants