feat: adopt hubble sdk on notebook login #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcg1
requested changes
Oct 14, 2022
Co-authored-by: Alex Cureton-Griffiths <alexcg1@users.noreply.github.com>
Co-authored-by: Alex Cureton-Griffiths <alexcg1@users.noreply.github.com>
Co-authored-by: Alex Cureton-Griffiths <alexcg1@users.noreply.github.com>
Co-authored-by: Alex Cureton-Griffiths <alexcg1@users.noreply.github.com>
Co-authored-by: Alex Cureton-Griffiths <alexcg1@users.noreply.github.com>
Co-authored-by: Alex Cureton-Griffiths <alexcg1@users.noreply.github.com>
Co-authored-by: Alex Cureton-Griffiths <alexcg1@users.noreply.github.com>
…tuner into feat-notebook-login
|
@alexcg1 if you find this looks good please review again, otherwise will block us from merge |
alexcg1
requested changes
Oct 14, 2022
gmastrapas
approved these changes
Oct 14, 2022
|
test failed blocked by : jina-ai/jina-hubble-sdk#83 |
gmastrapas
requested changes
Oct 16, 2022
LMMilliken
approved these changes
Oct 17, 2022
guenthermi
approved these changes
Oct 17, 2022
| """Log in to Hubble account, initialize a client object | ||
| and create a default experiment. | ||
|
|
||
| :param force: If set to true, overwrite token and re-login. |
There was a problem hiding this comment.
Can you add the force parameter also to the login function. It also exists there.
gmastrapas
requested changes
Oct 17, 2022
docs/tasks/text-to-image.md
Outdated
| @@ -11,7 +11,7 @@ For each product the dataset contains a title and images of multiple variants of | |||
|
|
|||
| ## Data | |||
| Our journey starts locally. We have to {ref}`prepare the data and push it to the cloud <create-training-data>` and Finetuner will be able to get the dataset by its name. For this example, | |||
| we already prepared the data, and we'll provide the names of training and evaluation data (`clip-fashion-train-data` and `clip-fashion-eval-data`) directly to Finetuner. | |||
| we already prepared the data, and we'll provide the names of training and evaluation data (`fashion-eval-train-clip` and `fashion-eval-data-clip`) directly to Finetuner. | |||
There was a problem hiding this comment.
the train data are fashion-train-data-clip. Update the snippet as well
|
📝 Docs are deployed on https://ft-feat-notebook-login--jina-docs.netlify.app 🎉 |
gmastrapas
approved these changes
Oct 17, 2022
|
📝 Docs are deployed on https://ft-feat-notebook-login--jina-docs.netlify.app 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest hubble sdk release brings finetuner sdk user experience improvement, see screenshot as follows:
After success: