feat: validate run configs #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 17, 2022 16:22
github-actions
bot
added
size/s
area/core
area/testing
|
Currently, the config classes in the latest release do not actually perform validation, though default values are now assigned by the config classes so a unit test had to be changed |
gmastrapas
previously requested changes
Oct 20, 2022
added 2 commits
October 20, 2022 14:39
…a-ai/finetuner into feat-validate-configs
gmastrapas
requested changes
Oct 26, 2022
bwanglzu
requested changes
Oct 26, 2022
gmastrapas
reviewed
Oct 26, 2022
LMMilliken
force-pushed
the
feat-validate-configs
branch
from
fc4bcee
to
99ad380
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes use of the config classes in stubs when creating a run config.