-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: show progress while encoding #586
Conversation
@@ -22,6 +22,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
|
|||
- Update the open clip model names in the table of the backbones. ([#580](https://github.com/jina-ai/finetuner/pull/580)) | |||
|
|||
- Show progress while encode batches of documents. ([#586](https://github.com/jina-ai/finetuner/pull/586)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
while encoding
if not device: | ||
device = 'cuda' if torch.cuda.is_available() else 'cpu' | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I add this change to the build model function in pr #584?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes please
Usability improvements
encode
:device
is not provided.show_progress
while batching DocumentArray when callingencode
.