Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump hubble sdk #594

Merged
merged 10 commits into from Nov 10, 2022
Merged

chore: bump hubble sdk #594

merged 10 commits into from Nov 10, 2022

Conversation

bwanglzu
Copy link
Member

@bwanglzu bwanglzu commented Nov 3, 2022 •
edited

In the latest jina-hubble-sdk, notebook_login has been merged into login by automatic detecting env

  • This PR references an open issue
  • I have added a line about this change to CHANGELOG

@bwanglzu
Copy link
Member Author

bwanglzu commented Nov 3, 2022

do not merge until core updated

@bwanglzu bwanglzu marked this pull request as ready for review November 10, 2022 14:40
guenthermi
guenthermi approved these changes Nov 10, 2022
View reviewed changes
docs/walkthrough/login.md Show resolved Hide resolved
gmastrapas
gmastrapas reviewed Nov 10, 2022
View reviewed changes
Copy link
Member

@gmastrapas gmastrapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont see a bump in hubble? What about stubs and commons? should we bump?

LMMilliken
LMMilliken approved these changes Nov 10, 2022
View reviewed changes
Copy link
Contributor

@LMMilliken LMMilliken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, maybe these removed comments could just be reworded instead

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
docs/walkthrough/login.md Show resolved Hide resolved
docs/walkthrough/save-model.md Show resolved Hide resolved
@github-actions github-actions bot added the area/testing This issue/PR affects testing label Nov 10, 2022
@bwanglzu
Copy link
Member Author

@gmastrapas that one has been taken care by #602

@github-actions
Copy link

📝 Docs are deployed on https://ft-chore-hubble-sdk--jina-docs.netlify.app 🎉

@gmastrapas gmastrapas merged commit 89b3bc5 into main Nov 10, 2022
@gmastrapas gmastrapas deleted the chore-hubble-sdk branch November 10, 2022 15:51
@guenthermi guenthermi restored the chore-hubble-sdk branch February 13, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guenthermi guenthermi guenthermi approved these changes

@gmastrapas gmastrapas gmastrapas approved these changes

@LMMilliken LMMilliken LMMilliken approved these changes

Assignees
No one assigned
Labels
area/core area/docs area/entrypoint area/testing This issue/PR affects testing size/s
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bwanglzu @guenthermi @gmastrapas @LMMilliken