refactor: add docs and remove connect function #596
Conversation
guenthermi
requested review from
gmastrapas,
bwanglzu,
LMMilliken and
scott-martens
and removed request for
gmastrapas
Co-authored-by: George Mastrapas <32414777+gmastrapas@users.noreply.github.com>
docs/notebooks/text_to_image.ipynb
Outdated
| @@ -280,7 +281,7 @@ | |||
| "cell_type": "code", | |||
| "source": [ | |||
| "text_da = DocumentArray([Document(text='some text to encode')])\n", | |||
| "image_da = DocumentArray([Document(uri='my-image.png')])\n", | |||
| "image_da = DocumentArray([Document(uri='https://www.collinsdictionary.com/images/full/apple_158989157.jpg')])\n", | |||
There was a problem hiding this comment.
Not a free-use image. Try to use free-use images with known origins and stable URLs. Like this one: https://upload.wikimedia.org/wikipedia/commons/4/4e/Single_apple.png
docs/notebooks/text_to_image.md
Outdated
| @@ -177,7 +177,7 @@ let's use the fine-tuned model to encode a new `Document`: | |||
|
|
|||
| ```python id="v95QsuEyzE-B" | |||
| text_da = DocumentArray([Document(text='some text to encode')]) | |||
| image_da = DocumentArray([Document(uri='my-image.png')]) | |||
| image_da = DocumentArray([Document(uri='https://www.collinsdictionary.com/images/full/apple_158989157.jpg')]) | |||
There was a problem hiding this comment.
Not a free-use image. Try to use free-use images with known origins and stable URLs. Like this one: https://upload.wikimedia.org/wikipedia/commons/4/4e/Single_apple.png
|
Docs look fine except for the apple picture not being free-use and not having any guarantee of a stable URL. Replace it with https://upload.wikimedia.org/wikipedia/commons/4/4e/Single_apple.png |
|
ok it produced lots of changes in the text-to-text colab, but I did not found a way to prevent it from it, without edititing the source code of the colab manually. |
|
📝 Docs are deployed on https://ft-refactor-login-functions--jina-docs.netlify.app 🎉 |
This PR fix some minor issues with the login functionalities and the documentation in general
connectfunction which got useless since theforceparameter was introduced by hubble