Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add before and after to text-text #622

Merged
merged 17 commits into from
Dec 14, 2022
Merged

docs: add before and after to text-text #622

merged 17 commits into from
Dec 14, 2022

Conversation

LMMilliken
Copy link
Contributor

@LMMilliken LMMilliken commented Nov 28, 2022

This pr adds a before/after section to the example notebooks, which shows the difference between the search results of the fine-tuned and zero-shot models

Several images have been added to the repo to serve as examples, in some cases these could be replaced by uris, in other cases they cannot


  • This PR references an open issue
  • I have added a line about this change to CHANGELOG

@LMMilliken LMMilliken self-assigned this Nov 28, 2022
@LMMilliken LMMilliken linked an issue Nov 28, 2022 that may be closed by this pull request
@github-actions github-actions bot added size/l and removed size/m labels Nov 28, 2022
@LMMilliken LMMilliken marked this pull request as ready for review November 28, 2022 17:06
Copy link
Member

@guenthermi guenthermi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some minor comments

docs/notebooks/image_to_image.md Outdated Show resolved Hide resolved
docs/notebooks/image_to_image.md Outdated Show resolved Hide resolved
docs/notebooks/text_to_image.md Outdated Show resolved Hide resolved
docs/notebooks/text_to_image.md Outdated Show resolved Hide resolved
docs/notebooks/text_to_text.md Outdated Show resolved Hide resolved
Copy link
Member

@guenthermi guenthermi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some small comments

docs/notebooks/image_to_image.md Outdated Show resolved Hide resolved

```python
import copy
from PIL import Image
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sort imports

docs/notebooks/text_to_image.md Outdated Show resolved Hide resolved
docs/notebooks/text_to_image.md Outdated Show resolved Hide resolved
docs/notebooks/multilingual_text_to_image.md Outdated Show resolved Hide resolved
docs/notebooks/text_to_text.md Outdated Show resolved Hide resolved
Co-authored-by: George Mastrapas <32414777+gmastrapas@users.noreply.github.com>
Copy link
Member

@bwanglzu bwanglzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! LGTM!

@github-actions
Copy link

📝 Docs are deployed on https://ft-docs-before-after--jina-docs.netlify.app 🎉

Copy link
Member

@guenthermi guenthermi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only added some small comments

if pt_q.text in seen:
continue
seen.add(pt_q.text)
print(f'results for query "{pt_q.text}" using a zero-shot model (top) and the fine-tuned model (bottom):')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please split the string, otherwise one has to scroll left and right in the docs

i = i - 1
continue
seen.add(pt_q.text)
print(f'results for query "{pt_q.text}" using a zero-shot model (top) and the fine-tuned model (bottom):')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also split this string


To save you some time, we have plotted some examples where the model's ability to return similar images has clearly improved:

![image-image-triplets-good](images/image-image-triplets-good.png)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The images presented in the last row missing the text. Maybe you can fix this if it is not too hard.

@github-actions
Copy link

📝 Docs are deployed on https://ft-docs-before-after--jina-docs.netlify.app 🎉

@LMMilliken LMMilliken merged commit f2b2980 into main Dec 14, 2022
@LMMilliken LMMilliken deleted the docs-before-after branch December 14, 2022 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add before/after comparisons at the end of notebooks
4 participants