-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add before and after to text-text #622
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some minor comments
5ba26df
to
4ff77ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some small comments
docs/notebooks/image_to_image.md
Outdated
|
||
```python | ||
import copy | ||
from PIL import Image |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sort imports
76a670a
to
f4ef9d7
Compare
Co-authored-by: George Mastrapas <32414777+gmastrapas@users.noreply.github.com>
a4692f5
to
d7423d1
Compare
f51b532
to
ca6b443
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! LGTM!
4256561
to
284b51b
Compare
📝 Docs are deployed on https://ft-docs-before-after--jina-docs.netlify.app 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, only added some small comments
docs/notebooks/text_to_image.md
Outdated
if pt_q.text in seen: | ||
continue | ||
seen.add(pt_q.text) | ||
print(f'results for query "{pt_q.text}" using a zero-shot model (top) and the fine-tuned model (bottom):') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please split the string, otherwise one has to scroll left and right in the docs
i = i - 1 | ||
continue | ||
seen.add(pt_q.text) | ||
print(f'results for query "{pt_q.text}" using a zero-shot model (top) and the fine-tuned model (bottom):') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also split this string
|
||
To save you some time, we have plotted some examples where the model's ability to return similar images has clearly improved: | ||
|
||
![image-image-triplets-good](images/image-image-triplets-good.png) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The images presented in the last row missing the text. Maybe you can fix this if it is not too hard.
📝 Docs are deployed on https://ft-docs-before-after--jina-docs.netlify.app 🎉 |
This pr adds a before/after section to the example notebooks, which shows the difference between the search results of the fine-tuned and zero-shot models
Several images have been added to the repo to serve as examples, in some cases these could be replaced by uris, in other cases they cannot