Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: deprecate cpu #631

Merged
merged 7 commits into from
Dec 14, 2022
Merged

refactor: deprecate cpu #631

merged 7 commits into from
Dec 14, 2022

Conversation

LMMilliken
Copy link
Contributor

@LMMilliken LMMilliken commented Dec 5, 2022 •
edited
Loading

In preparation of finetuner 0.7.0, this pr removed the cpu parameter from the create_run method

  • This PR references an open issue
  • I have added a line about this change to CHANGELOG

@LMMilliken LMMilliken linked an issue Dec 5, 2022 that may be closed by this pull request
deprecate cpu after 0.7.0 #578
Closed
@LMMilliken LMMilliken marked this pull request as ready for review December 5, 2022 15:57
gmastrapas
gmastrapas reviewed Dec 5, 2022
View reviewed changes
Copy link
Member

@gmastrapas gmastrapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we use it in finetuner.encode too?

bwanglzu
bwanglzu requested changes Dec 6, 2022
View reviewed changes
Copy link
Member

@bwanglzu bwanglzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also remove notebook_login. Do not merge it, we'll merge until 0.7.0. This will go together with self-hosted features.

@LMMilliken
Copy link
Contributor Author

Do we use it in finetuner.encode too?

All occurances of the cpu parameter have been removed

@LMMilliken LMMilliken self-assigned this Dec 6, 2022
bwanglzu
bwanglzu approved these changes Dec 14, 2022
View reviewed changes
Copy link
Member

@bwanglzu bwanglzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions github-actions bot added the area/testing This issue/PR affects testing label Dec 14, 2022
@LMMilliken LMMilliken merged commit e535e6a into main Dec 14, 2022
@LMMilliken LMMilliken deleted the refactor-deprecate-cpu branch December 14, 2022 13:23
@scott-martens scott-martens mentioned this pull request Jan 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwanglzu bwanglzu bwanglzu approved these changes

@gmastrapas gmastrapas gmastrapas approved these changes

@guenthermi guenthermi Awaiting requested review from guenthermi

Assignees

@LMMilliken LMMilliken

Labels
area/core area/entrypoint area/testing This issue/PR affects testing size/s
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

deprecate cpu after 0.7.0
3 participants
@LMMilliken @bwanglzu @gmastrapas