-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add csv parsing for meshes and tutorial #638
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please also fix the `describe_models, link: https://ft-docs-add-3d-mesh-example--jina-docs.netlify.app/docs-add-3d-mesh-example/walkthrough/choose-backbone/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
two small things
if create_point_clouds and os.path.isfile(column): | ||
doc.load_uri_to_point_cloud_tensor(point_cloud_size) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this document would be unusable if create_point_clouds
is False but column
is a local file right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes more or less, but it is the same for images when you set convert_to_blob=False
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point, maybe both of these cases should raise an error or warning
|
||
```python id="vDVkw65kkQcn" | ||
!pip install 'finetuner[full]' | ||
!pip install 'docarray[full]' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's remove this from the tutorial
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!, minor comment
Oh yes, this is terrible. I can add a white backround surronding all the image of the meshes |
CHANGELOG.md
Outdated
- Ass support for 3d meshes to `build_finetuning_dataset`. ([#638](https://github.com/jina-ai/finetuner/pull/638)) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small thing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
📝 Docs are deployed on https://ft-docs-add-3d-mesh-example--jina-docs.netlify.app 🎉 |
is there an error in |
Add csv parsing for meshes and tutorial