Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add documentation for GeM pooling #684

Merged
merged 4 commits into from
Mar 1, 2023
Merged

docs: Add documentation for GeM pooling #684

merged 4 commits into from
Mar 1, 2023

Conversation

LMMilliken
Copy link
Contributor

@LMMilliken LMMilliken commented Mar 1, 2023

This pr adds the section on GeM pooling that was previously removed


  • This PR references an open issue
  • I have added a line about this change to CHANGELOG

@bwanglzu
Copy link
Member

bwanglzu commented Mar 1, 2023

if Scott approves, then feel free to merge

@LMMilliken LMMilliken self-assigned this Mar 1, 2023
Co-authored-by: Scott Martens <70647348+scott-martens@users.noreply.github.com>
@bwanglzu bwanglzu mentioned this pull request Mar 1, 2023
5 tasks
Co-authored-by: Scott Martens <70647348+scott-martens@users.noreply.github.com>
@github-actions
Copy link

github-actions bot commented Mar 1, 2023

📝 Docs are deployed on https://ft-docs-add-gem--jina-docs.netlify.app 🎉

@bwanglzu
Copy link
Member

bwanglzu commented Mar 1, 2023

let's add a small "insight" to tell users, combine GeM pooling together with ArcFaceLoss delivers better results.

Copy link
Member

@scott-martens scott-martens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bwanglzu bwanglzu merged commit df97e17 into main Mar 1, 2023
@bwanglzu bwanglzu deleted the docs-add-gem branch March 1, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants