Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for batch size scaling #691

Merged
merged 3 commits into from
Mar 16, 2023
Merged

Conversation

LMMilliken
Copy link
Contributor

@LMMilliken LMMilliken commented Mar 14, 2023

This pr sets batch_size to None by default in the fit function, meaning that if left unset, the batch size will be configured automatically in core.


  • This PR references an open issue
  • I have added a line about this change to CHANGELOG

Copy link
Member

@bwanglzu bwanglzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@LMMilliken LMMilliken merged commit 16ae4ff into main Mar 16, 2023
@LMMilliken LMMilliken deleted the feat-scale-batch-size branch March 16, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants