feat: add score document support in csv #696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LMMilliken
approved these changes
Mar 20, 2023
gmastrapas
reviewed
Mar 20, 2023
guenthermi
requested changes
Mar 20, 2023
Ok probably, there is nothing in the documentation about building dataset from CSV, because we only apply it automatically if one provides a file path in the csv. |
|
documentation will be added in a seperate PR: #688 (comment) |
gmastrapas
approved these changes
Mar 20, 2023
Co-authored-by: George Mastrapas <32414777+gmastrapas@users.noreply.github.com>
guenthermi
approved these changes
Mar 21, 2023
| @@ -70,7 +70,7 @@ def list_experiments(self, page: int = 1, size: int = 50) -> Dict[str, Any]: | |||
| ..note:: The maximum number for `size` per page is 100. | |||
| """ | |||
| params = {'page': page, 'size': size} | |||
| url = self._construct_url(self._base_url, API_VERSION, EXPERIMENTS) | |||
| url = self._construct_url(self._base_url, API_VERSION, EXPERIMENTS) + '/' | |||
There was a problem hiding this comment.
Can this be don in the construct_url function?
There was a problem hiding this comment.
later we will investigate why this is happening
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows user create a CSV file contains three columns, col1 and col2 are content, and col3 indicates the similarity between col1 and col2. Besides, I refactored the
build_finetuning_datasetfunction.