Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add optimizer and query document score #697

Merged
merged 17 commits into from
Mar 21, 2023
Merged

docs: add optimizer and query document score #697

merged 17 commits into from
Mar 21, 2023

Conversation

bwanglzu
Copy link
Member

@bwanglzu bwanglzu commented Mar 20, 2023

Since we're working on documentation restructuring, i only added these features into associated components (without optimization). The changes:

  1. layer-wise learning rate decay.
  2. query-document-score CSV preparation.
  3. CosineSimilarityLoss

  • This PR references an open issue
  • I have added a line about this change to CHANGELOG

@bwanglzu bwanglzu self-assigned this Mar 21, 2023
@bwanglzu bwanglzu marked this pull request as ready for review March 21, 2023 07:36
docs/walkthrough/create-training-data.md Show resolved Hide resolved
docs/walkthrough/create-training-data.md Show resolved Hide resolved
docs/walkthrough/run-job.md Outdated Show resolved Hide resolved
bwanglzu and others added 2 commits March 21, 2023 09:11
Co-authored-by: Louis Milliken <58855099+LMMilliken@users.noreply.github.com>
Co-authored-by: Louis Milliken <58855099+LMMilliken@users.noreply.github.com>
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Louis Milliken <58855099+LMMilliken@users.noreply.github.com>
docs/walkthrough/create-training-data.md Outdated Show resolved Hide resolved
docs/walkthrough/run-job.md Outdated Show resolved Hide resolved
docs/walkthrough/run-job.md Outdated Show resolved Hide resolved
Copy link
Member

@guenthermi guenthermi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only two small additional comments

docs/walkthrough/create-training-data.md Outdated Show resolved Hide resolved
bwanglzu and others added 2 commits March 21, 2023 10:32
Co-authored-by: Michael Günther <michael.guenther@jina.ai>
Co-authored-by: Michael Günther <michael.guenther@jina.ai>
@github-actions
Copy link

📝 Docs are deployed on https://ft-docs-loss-llrd--jina-docs.netlify.app 🎉

Copy link
Member

@scott-martens scott-martens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@LMMilliken LMMilliken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bwanglzu bwanglzu merged commit fac4180 into main Mar 21, 2023
@bwanglzu bwanglzu deleted the docs-loss-llrd branch March 21, 2023 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants