Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add notebook for data generation #745

Merged
merged 8 commits into from
May 24, 2023
Merged

docs: add notebook for data generation #745

merged 8 commits into from
May 24, 2023

Conversation

LMMilliken
Copy link
Contributor

@LMMilliken LMMilliken commented May 23, 2023 •
edited

image

  • This PR references an open issue
  • I have added a line about this change to CHANGELOG

@LMMilliken LMMilliken self-assigned this May 23, 2023
@LMMilliken LMMilliken marked this pull request as draft May 23, 2023 12:27
@LMMilliken LMMilliken linked an issue May 23, 2023 that may be closed by this pull request
GPL documentation #740
Closed
@github-actions github-actions bot added size/s area/core area/testing This issue/PR affects testing labels May 23, 2023
@LMMilliken LMMilliken marked this pull request as ready for review May 23, 2023 14:17
@LMMilliken LMMilliken requested a review from bwanglzu May 23, 2023 14:17
@github-actions github-actions bot added size/xl and removed size/s labels May 23, 2023
@github-actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

bwanglzu
bwanglzu approved these changes May 23, 2023
View reviewed changes
Copy link
Member

@bwanglzu bwanglzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bwanglzu bwanglzu requested a review from gmastrapas May 23, 2023 14:23
gmastrapas
gmastrapas approved these changes May 23, 2023
View reviewed changes
docs/notebooks/data_synthesis.md Outdated Show resolved Hide resolved
@LMMilliken @gmastrapas
Update docs/notebooks/data_synthesis.md
2126165 
Co-authored-by: George Mastrapas <32414777+gmastrapas@users.noreply.github.com>
@github-actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions
Copy link

📝 Docs are deployed on https://ft-docs-gpl--jina-docs.netlify.app 🎉

@LMMilliken LMMilliken merged commit dcc965a into main May 24, 2023
8 checks passed
@LMMilliken LMMilliken deleted the docs-gpl branch May 24, 2023 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwanglzu bwanglzu bwanglzu approved these changes

@gmastrapas gmastrapas gmastrapas approved these changes

Assignees

@LMMilliken LMMilliken

Labels
area/core area/docs area/entrypoint area/setup area/testing This issue/PR affects testing size/xl
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GPL documentation
3 participants
@LMMilliken @bwanglzu @gmastrapas