Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: create synthesis run should accept da as input #748

Merged
merged 2 commits into from
Jun 1, 2023
Merged

fix: create synthesis run should accept da as input #748

merged 2 commits into from
Jun 1, 2023

Conversation

bwanglzu
Copy link
Member

@bwanglzu bwanglzu commented May 31, 2023 •
edited

Create synthesis run currently only accepts a str is the name of the DoccumentArray, or a list of str which is to used to construct a DocumentArray, but if user give a DA, it is not accepted.

  • This PR references an open issue
  • I have added a line about this change to CHANGELOG

@bwanglzu bwanglzu merged commit 4c91fa1 into main Jun 1, 2023
8 checks passed
@bwanglzu bwanglzu deleted the fix-synthesis branch June 1, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmastrapas gmastrapas gmastrapas approved these changes

@LMMilliken LMMilliken LMMilliken approved these changes

@guenthermi guenthermi Awaiting requested review from guenthermi

Assignees
No one assigned
Labels
area/core size/s
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bwanglzu @gmastrapas @LMMilliken