Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add multilingual model #750

Merged
merged 9 commits into from
Jun 7, 2023
Merged

feat: add multilingual model #750

merged 9 commits into from
Jun 7, 2023

Conversation

bwanglzu
Copy link
Member

@bwanglzu bwanglzu commented Jun 7, 2023 •
edited

  1. bump commons and stubs to latest core release
  2. update supported backbones
  3. update data synthesis notebook
  • This PR references an open issue
  • I have added a line about this change to CHANGELOG

@github-actions github-actions bot added size/xl and removed size/s labels Jun 7, 2023
@github-actions
Copy link

github-actions bot commented Jun 7, 2023

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@bwanglzu bwanglzu marked this pull request as ready for review June 7, 2023 12:21
@github-actions
Copy link

github-actions bot commented Jun 7, 2023

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions
Copy link

github-actions bot commented Jun 7, 2023

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

LMMilliken
LMMilliken approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@LMMilliken LMMilliken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link

github-actions bot commented Jun 7, 2023

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions
Copy link

github-actions bot commented Jun 7, 2023

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

gmastrapas
gmastrapas approved these changes Jun 7, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
docs/notebooks/data_synthesis.md Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Jun 7, 2023

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions
Copy link

github-actions bot commented Jun 7, 2023

📝 Docs are deployed on https://ft-feat-muti-encoder--jina-docs.netlify.app 🎉

@bwanglzu bwanglzu merged commit ca3f77e into main Jun 7, 2023
8 checks passed
@bwanglzu bwanglzu deleted the feat-muti-encoder branch June 7, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmastrapas gmastrapas gmastrapas approved these changes

@LMMilliken LMMilliken LMMilliken approved these changes

@guenthermi guenthermi Awaiting requested review from guenthermi

Assignees
No one assigned
Labels
area/core area/docs area/entrypoint area/setup size/xl
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bwanglzu @gmastrapas @LMMilliken