feat: support loading models from hf #751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guenthermi
requested review from
gmastrapas,
bwanglzu and
LMMilliken
and removed request for
gmastrapas and
bwanglzu
LMMilliken
suggested changes
Jun 7, 2023
Comment on lines
15
to
17
| def test_download_hf_model(model): | ||
| path = download_huggingface_model(model) | ||
| assert os.path.isdir(path) |
There was a problem hiding this comment.
could we also check that we can successfully build the model from the contents of this path?
bwanglzu
reviewed
Jun 7, 2023
Comment on lines
+97
to
+98
| HF_URL_PREFIX = 'https://huggingface.co/jinaai/' | ||
| HF_ORG_PREFIX = 'jinaai/' |
There was a problem hiding this comment.
when we have the push function, let's remove the org restriction
gmastrapas
reviewed
Jun 7, 2023
finetuner/__init__.py
Outdated
| @@ -517,6 +519,29 @@ def build_model( | |||
| ) | |||
|
|
|||
|
|
|||
| def download_huggingface_model(model_name: str, token: Optional[str] = None) -> str: | |||
There was a problem hiding this comment.
is this meant to be public? if not, use an _ in front of the name
There was a problem hiding this comment.
I was not sure, maybe private is better
| :param token: Optional token to access private models. | ||
| :return: The local path to the downloaded model. | ||
| """ | ||
| from huggingface_hub import hf_hub_download, list_repo_files |
There was a problem hiding this comment.
we have transformers already as a dependency which depends on it. Should we add it anyway?
Co-authored-by: George Mastrapas <32414777+gmastrapas@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: support loading models from hf
This PR allows one to load models from https://huggingface.co/jinaai: