Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add jina embedding models #757

Merged
merged 6 commits into from
Jul 11, 2023
Merged

feat: add jina embedding models #757

merged 6 commits into from
Jul 11, 2023

Conversation

bwanglzu
Copy link
Member

@bwanglzu bwanglzu commented Jul 10, 2023 •
edited

Add jina embedding models

  • This PR references an open issue
  • I have added a line about this change to CHANGELOG

@bwanglzu bwanglzu marked this pull request as ready for review July 10, 2023 16:05
gmastrapas
gmastrapas approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@gmastrapas gmastrapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@bwanglzu bwanglzu requested a review from LMMilliken July 11, 2023 06:43
LMMilliken
LMMilliken approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@LMMilliken LMMilliken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bwanglzu bwanglzu merged commit fa9d73a into main Jul 11, 2023
8 checks passed
@bwanglzu bwanglzu deleted the feat-jina-embeddings branch July 11, 2023 06:45
@bwanglzu bwanglzu mentioned this pull request Jul 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmastrapas gmastrapas gmastrapas approved these changes

@LMMilliken LMMilliken LMMilliken approved these changes

@guenthermi guenthermi Awaiting requested review from guenthermi

Assignees
No one assigned
Labels
area/core area/docs area/entrypoint area/setup size/s
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bwanglzu @gmastrapas @LMMilliken