This repository has been archived by the owner on Aug 31, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The work on |
Yongxuanzhang
force-pushed
the
postgresql-indexer
branch
from
March 25, 2021 01:17
747fd07
to
f7d0b31
Compare
cristianmtr
reviewed
Apr 16, 2021
cristianmtr
reviewed
Apr 16, 2021
cristianmtr
reviewed
Apr 16, 2021
cristianmtr
reviewed
Apr 16, 2021
cristianmtr
reviewed
Apr 16, 2021
cristianmtr
suggested changes
Apr 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still some things to address
JoanFM
reviewed
Apr 16, 2021
cristianmtr
force-pushed
the
postgresql-indexer
branch
from
April 21, 2021 09:38
686d6c5
to
d4bbe9e
Compare
cristianmtr
previously approved these changes
Apr 21, 2021
cristianmtr
force-pushed
the
postgresql-indexer
branch
from
April 21, 2021 09:55
d4bbe9e
to
0dddfe7
Compare
cristianmtr
force-pushed
the
postgresql-indexer
branch
from
April 21, 2021 09:57
0dddfe7
to
89dd775
Compare
cristianmtr
approved these changes
Apr 21, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Postgress Indexer.
Benchmark
NOTE: PSQL indexing can be optimized by inserting all in one go (for a future PR)
Compare w BinaryPb and Base here: jina-ai/jina#2307