Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug test failing for audio search #2081

Closed
lusloher opened this issue Mar 1, 2021 · 1 comment
Closed

bug test failing for audio search #2081

lusloher opened this issue Mar 1, 2021 · 1 comment
Labels
area/core This issue/PR affects the core codebase priority/critical Urgent: Security, critical bugs, blocking issues. drop everything until this issue is addressed. status/available The issue is available for someone to begin working on. type/bug Something isn't working

Comments

@lusloher
Copy link

lusloher commented Mar 1, 2021 •
edited

Bug Report

Need to test all examples with Jina version 1.0 and fix these tests. Issue may have occurred due to changes on Rankers.

The test can pass on 1.0.1 but fail on 1.0.2, so most likely jina-ai/jina#1973 is the reason why tests fail

Meanwhile, multires-lyrics-search will encounter:AttributeError("'KVSearchDriver' object has no attribute '_is_update'") when searching in jinabox frontend.

  •  CI: set fail-fast false to enable running all tests.

  •  fix: audio search and test

  •  fix: tumblr-gif-search

  •  fix: multires-lyrics-search

Possible solutions:
jina-ai/jina-hub#4144
@lusloher
Copy link
Author

lusloher commented Mar 1, 2021

Link to feature: https://jinaai.productboard.com/feature-board/planning/features/7101190

@FionnD FionnD added area/core This issue/PR affects the core codebase priority/critical Urgent: Security, critical bugs, blocking issues. drop everything until this issue is addressed. status/available The issue is available for someone to begin working on. type/bug Something isn't working labels Mar 1, 2021
@FionnD FionnD closed this as completed Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase priority/critical Urgent: Security, critical bugs, blocking issues. drop everything until this issue is addressed. status/available The issue is available for someone to begin working on. type/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@FionnD @lusloher