Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hub-integration): apply changes needed for Executor arm64 support #5582

Closed
wants to merge 5 commits into from

Conversation

nomagick
Copy link
Member

@nomagick nomagick commented Jan 9, 2023

Goals:

  • jina-hubble-sdk recently provided --platform parameter for Executor push and --prefer-platform for Executor pull
  • Update related tests to new version of fetch_meta provided by the SDK
  • Automated updates of command-line arguments
  • check and update documentation. See guide and ask the team.

@github-actions github-actions bot added size/XS area/testing This issue/PR affects testing labels Jan 9, 2023
@github-actions github-actions bot added size/S area/cli This issue/PR affects the command line interface labels Jan 9, 2023
@codecov
Copy link

codecov bot commented Jan 9, 2023

Codecov Report

Merging #5582 (597c07d) into master (139cd2b) will decrease coverage by 0.56%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #5582      +/-   ##
==========================================
- Coverage   87.51%   86.94%   -0.57%     
==========================================
  Files         123      123              
  Lines        9838     9839       +1     
==========================================
- Hits         8610     8555      -55     
- Misses       1228     1284      +56     
Flag Coverage Δ
jina 86.94% <100.00%> (-0.57%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/orchestrate/flow/base.py 90.15% <ø> (ø)
jina/serve/executors/__init__.py 83.75% <ø> (-5.42%) ⬇️
jina/parsers/orchestrate/pod.py 100.00% <100.00%> (ø)
jina/serve/monitoring.py 57.14% <0.00%> (-42.86%) ⬇️
jina/serve/runtimes/monitoring.py 89.36% <0.00%> (-10.64%) ⬇️
jina/serve/executors/decorators.py 90.76% <0.00%> (-6.16%) ⬇️
jina/serve/runtimes/worker/__init__.py 90.71% <0.00%> (-5.00%) ⬇️
jina/serve/runtimes/worker/request_handling.py 92.34% <0.00%> (-3.83%) ⬇️
jina/serve/networking.py 88.52% <0.00%> (-0.39%) ⬇️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions github-actions bot added the area/core This issue/PR affects the core codebase label Jan 9, 2023
@nomagick nomagick changed the title test(hub-integration): fix mocked function according to the latest sdk fix(hub-integration): apply changes needed for latest sdk Jan 9, 2023
@github-actions github-actions bot added the area/docs This issue/PR affects the docs label Jan 9, 2023
@nomagick nomagick changed the title fix(hub-integration): apply changes needed for latest sdk fix(hub-integration): apply changes needed for Executor arm64 support Jan 9, 2023
@github-actions
Copy link

📝 Docs are deployed on https://fix-sdk-integration--jina-docs.netlify.app 🎉

@nomagick
Copy link
Member Author

nomagick commented Feb 1, 2023

Closing due to too many conflicts. Will rebase to new separate PRs.

@nomagick nomagick closed this Feb 1, 2023
@JoanFM JoanFM deleted the fix-sdk-integration branch November 13, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli This issue/PR affects the command line interface area/core This issue/PR affects the core codebase area/docs This issue/PR affects the docs area/testing This issue/PR affects testing size/M size/S size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants