Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: use K8sDeploymentConfig inside Deployment to generate kubernetes yamls #5584

Closed
alaeddine-13 opened this issue Jan 9, 2023 · 0 comments · Fixed by #5608
Closed

Comments

@alaeddine-13
Copy link
Contributor

After Deployment is exposed to serve Executors, we want to use it in order to generate kubernetes yaml as well.
This means, the Deployment should use K8sDeploymentConfig to implement to_kubernetes_yaml.

Potentially, we also want to refactor Flow.to_kubernetes_yaml to use the new method and maybe the same for Executor (or deprecate Executor.to_kubernetes_yaml)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant